add evaluateFunctionExit for backward analyzer in monotone-analyzer - #7547
Conversation
|
Makes sense, but would it be possible to add some usage somewhere to avoid this getting deleted as dead code in the future? |
|
I am writing our own pass to analyze the opcode between |
|
Would you be interested in upstreaming the pass you're writing? If not, and you're maintaining downstream patches, what's the benefit of having this function upstream? |
I am not sure the attitude of the bianryen community to frontend language specific pass. I guess it only welcomes the common part.
To make the lattice based analysis framework more complete. If it is not needed, feel free to close this PR. |
|
There is some precedent for having frontend-specific passes in Binaryen. We have J2CLOpts.cpp, which is specific to the j2wasm compiler, for example. We could consider adding more frontend-specific passes on a case-by-case basis. This would have the benefit to you of making sure your pass isn't broken if we refactor the static analysis framework and would also make sure that we have test coverage for the new method in this PR. Alternatively we can just land this PR as-is, but be aware that future refactors might break your downstream pass unexpectedly. This isn't meant to be a stable, external-facing API. |
|
I prefer to merge it as current PR.
It is fine since normally only C api is stable. |
tlively
left a comment
There was a problem hiding this comment.
Ok, this seems fine to merge, then.
For backward analyzer, it is helpful to have a function to init state in the "entry point" (exit block).